xfs
[Top] [All Lists]

Re: Bug#793495: xfsprogs fails to build on debian ppc64el

To: Dave Chinner <david@xxxxxxxxxxxxx>, 793495@xxxxxxxxxxxxxxx
Subject: Re: Bug#793495: xfsprogs fails to build on debian ppc64el
From: Fernando Seiti Furusato <ferseiti@xxxxxxxxxxxxxxxxxx>
Date: Tue, 04 Aug 2015 12:24:06 -0300
Cc: Daniel Bast <daniel.bast@xxxxxxx>, xfs@xxxxxxxxxxx, Breno Leitao <brenohl@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150802221301.GO3902@dastard>
References: <55BB9271.6000300@xxxxxxx> <55BBEF4F.6070809@xxxxxxxxxxxxxxxxxx> <20150801225230.GR16638@dastard> <41BF7556-AAAB-4F22-B8C2-8991A0917DE2@xxxxxxx> <20150802221301.GO3902@dastard>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
Hi Dave.

I have just noticed that for config.guess and config.sub to be updated, no
autoreconf or dh_autotools-dev is needed, because of how Makefile was made.

In Makefile, @row 80:

 LIBTOOLIZE_INSTALL = `libtoolize -n -i >/dev/null 2>/dev/null && echo -i`

 configure:
         libtoolize -c $(LIBTOOLIZE_INSTALL) -f
         cp include/install-sh .
         aclocal -I m4
         autoconf

This runs libtoolize -c -i which updates those files.

The file debian/rules runs `make default`, which at some point calls the target
above (`make configure`). But the file configure already exists, so it does not
run.

Curiously, running `dpkg-buildpackage` twice, causes configure file to be
deleted, and the build completes without errors.

So, answering to your question:

> Nowdays, the generated files in the 3.2.4 tarball created via a
> 'make dist' rule. I run that on an up to date debian unstable box
> with autoconfig 2.69 installed to generate the files, so the
> question I have is this: why is an up-to-date build box generating
> "out of date" configure/m4 scripts? What, exactly, is out of date,
> and how do I ensure that the pre-build config files are correctly
> up-to-date?

The configure file comes shipped with the debian package, so that specific file
is not re-generated and is always out of date.
By the looks of the Makefile, there is no need to include autoreconf or autotools-dev in debian/rules, but to force `make distclean` to `rm configure`.

Attached is a patch that summarizes that, but for some reason it does not work
when running with parallel jobs enabled. But you can get the idea :)

Regards.
--

Fernando Seiti Furusato
IBM Linux Technology Center

Attachment: patch_xfsprogs.debdiff
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>