xfs
[Top] [All Lists]

Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was miss

To: Jan Tulak <jtulak@xxxxxxxxxx>
Subject: Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 4 Aug 2015 04:18:12 -0700
Cc: xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1438680314-23950-1-git-send-email-jtulak@xxxxxxxxxx>
References: <1438612789-17486-5-git-send-email-jtulak@xxxxxxxxxx> <1438680314-23950-1-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Aug 04, 2015 at 11:25:14AM +0200, Jan Tulak wrote:
> Add check for _DIRENT_HAVED_RECLEN/_OFF to read_directory().
> In dump_dirent() these checks already are used, but they were
> missing in read_directory.

Needs to be fixed to avoid > 80 char lines.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>