xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: fix syntax error in include/buildmacros

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix syntax error in include/buildmacros
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 4 Aug 2015 04:16:35 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1438659509-16656-1-git-send-email-eguan@xxxxxxxxxx>
References: <1438659509-16656-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Aug 04, 2015 at 11:38:29AM +0800, Eryu Guan wrote:
> There's an extra ";" in include/buildmacros, which causes make
> install-dev to fail
> 
>     ......
>     Installing libhandle-install-dev
>     cd ../libhandle/.libs; ... if [ "x/usr/lib64" != "x/usr/lib64"; ]; ...
>     /bin/sh: line 0: [: missing `]'
>     /bin/sh: ]: command not found
>     ......
> 
> This was introduced by
> 02ef543 libhandle: fix installation for symlinked /usr

Thanks, loosk like some shells are stricter than others here.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>