xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs: fix sb_meta_uuid usage

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/4] xfs: fix sb_meta_uuid usage
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 03 Aug 2015 09:27:50 -0700
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <55BF92DF.6080506@xxxxxxxxxxx>
References: <1438587625-31437-1-git-send-email-david@xxxxxxxxxxxxx> <1438587625-31437-2-git-send-email-david@xxxxxxxxxxxxx> <55BF92DF.6080506@xxxxxxxxxxx>
On 8/3/15 9:12 AM, Eric Sandeen wrote:
> On 8/3/15 12:40 AM, Dave Chinner wrote:
>> From: Dave Chinner <dchinner@xxxxxxxxxx>
>>
>> After changing the UUID on a v5 filesystem, xfstests fails
>> immediately on a debug kernel with:
>>
>> XFS: Assertion failed: uuid_equal(&ip->i_d.di_uuid, &mp->m_sb.sb_uuid), 
>> file: fs/xfs/xfs_inode.c, line: 799
>>
>> This needs to check against the sb_meta_uuid, not the user visible
>> UUID that was changed.
>>
>> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> first of a few brown paper bags for me :(  I guess I didn't test on debug 
> after all.  :(

Actually I did, this was also in my prior patches.  Le sigh.

-Eric

<Prev in Thread] Current Thread [Next in Thread>