Re: [PATCH 4/4] xfs: dquots should be stamped with sb_meta_uuid

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 8/3/15 12:40 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Once the sb_uuid is changed, the wrong uuid is stamped into new
> dquots on disk. Found by inspection, verified by generic/219.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  fs/xfs/xfs_dquot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
> index 4143dc7..b1b26b6 100644
> --- a/fs/xfs/xfs_dquot.c
> +++ b/fs/xfs/xfs_dquot.c
> @@ -251,7 +251,7 @@ xfs_qm_init_dquot_blk(
>               d->dd_diskdq.d_id = cpu_to_be32(curid);
>               d->dd_diskdq.d_flags = type;
>               if (xfs_sb_version_hascrc(&mp->m_sb)) {
> -                     uuid_copy(&d->dd_uuid, &mp->m_sb.sb_uuid);
> +                     uuid_copy(&d->dd_uuid, &mp->m_sb.sb_meta_uuid);
>                       xfs_update_cksum((char *)d, sizeof(struct xfs_dqblk),
>                                        XFS_DQUOT_CRC_OFF);
>               }
>