xfs
[Top] [All Lists]

[PATCH 4/4] xfs: dquots should be stamped with sb_meta_uuid

To: xfs@xxxxxxxxxxx
Subject: [PATCH 4/4] xfs: dquots should be stamped with sb_meta_uuid
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 3 Aug 2015 17:40:25 +1000
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1438587625-31437-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1438587625-31437-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

Once the sb_uuid is changed, the wrong uuid is stamped into new
dquots on disk. Found by inspection, verified by generic/219.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 fs/xfs/xfs_dquot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
index 4143dc7..b1b26b6 100644
--- a/fs/xfs/xfs_dquot.c
+++ b/fs/xfs/xfs_dquot.c
@@ -251,7 +251,7 @@ xfs_qm_init_dquot_blk(
                d->dd_diskdq.d_id = cpu_to_be32(curid);
                d->dd_diskdq.d_flags = type;
                if (xfs_sb_version_hascrc(&mp->m_sb)) {
-                       uuid_copy(&d->dd_uuid, &mp->m_sb.sb_uuid);
+                       uuid_copy(&d->dd_uuid, &mp->m_sb.sb_meta_uuid);
                        xfs_update_cksum((char *)d, sizeof(struct xfs_dqblk),
                                         XFS_DQUOT_CRC_OFF);
                }
-- 
2.1.4

<Prev in Thread] Current Thread [Next in Thread>