Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split

Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item

To:	Theodore Ts'o <tytso@xxxxxxx>
Subject:	Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 30 Jul 2015 10:11:28 -0700
Cc:	xfs@xxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1437913255-7524-5-git-send-email-tytso@xxxxxxx>
References:	<1437913255-7524-1-git-send-email-tytso@xxxxxxx> <1437913255-7524-5-git-send-email-tytso@xxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Sun, Jul 26, 2015 at 08:20:53AM -0400, Theodore Ts'o wrote:
> In Android's bionic libc (as well as the Linux kernel's
> include/uapi/asm-generic/siginfo.h), si_tid is a #define to provide
> backwards compatibility for the timerid in the siginfo structure.
> This breaks the compile of logprint/log_misc.c.  Change this to be
> si_xtid in order to avoid a namespace collision

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, (continued) Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Christoph Hellwig [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Theodore Ts'o Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Christoph Hellwig [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Theodore Ts'o Re: [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Christoph Hellwig [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Theodore Ts'o Re: [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Christoph Hellwig [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Theodore Ts'o Re: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Christoph Hellwig [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Theodore Ts'o Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Christoph Hellwig
Next by Date:	Re: [PATCH RFC 1/2] xfs: return committed status from xfs_trans_roll(), Christoph Hellwig
Previous by Thread:	[PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Theodore Ts'o
Next by Thread:	xfsprogs: fix and clean up installed headers V2, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]