Re: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename

To:	Theodore Ts'o <tytso@xxxxxxx>
Subject:	Re: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename()
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 30 Jul 2015 10:11:02 -0700
Cc:	xfs@xxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1437913255-7524-3-git-send-email-tytso@xxxxxxx>
References:	<1437913255-7524-1-git-send-email-tytso@xxxxxxx> <1437913255-7524-3-git-send-email-tytso@xxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

Looks fine, with the same caveat as the previous patch:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6] Add cross-compilation support for android, Theodore Ts'o [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Theodore Ts'o Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Christoph Hellwig [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Theodore Ts'o Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Christoph Hellwig [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Theodore Ts'o Re: [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Christoph Hellwig [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Theodore Ts'o Re: [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Christoph Hellwig [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Theodore Ts'o Re: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Christoph Hellwig <= [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Theodore Ts'o Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Christoph Hellwig

Previous by Date:	Re: [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Christoph Hellwig
Next by Date:	Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Christoph Hellwig
Previous by Thread:	[PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Theodore Ts'o
Next by Thread:	[PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Theodore Ts'o
Indexes:	[Date] [Thread] [Top] [All Lists]