Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system heade

To:	Theodore Ts'o <tytso@xxxxxxx>
Subject:	Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 30 Jul 2015 10:07:34 -0700
Cc:	xfs@xxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1437913255-7524-2-git-send-email-tytso@xxxxxxx>
References:	<1437913255-7524-1-git-send-email-tytso@xxxxxxx> <1437913255-7524-2-git-send-email-tytso@xxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Sun, Jul 26, 2015 at 08:20:50AM -0400, Theodore Ts'o wrote:
> Android's bionic libc doesn't define NBBY; this isn't a standard
> define, and since all modern/sane platforms have 8 bits per byte, use
> this as a default.
> 
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>

This looks fine, but it'll clash with my patch that changes
platform_defs.h so that it's not run through autoconfs m4 anymore.

Otherwise:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6] Add cross-compilation support for android, Theodore Ts'o [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Theodore Ts'o Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Christoph Hellwig [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Theodore Ts'o Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Christoph Hellwig <= [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Theodore Ts'o Re: [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Christoph Hellwig [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Theodore Ts'o Re: [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Christoph Hellwig [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Theodore Ts'o Re: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Christoph Hellwig [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Theodore Ts'o Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Christoph Hellwig

Previous by Date:	Processed: Re: Bug#793495: CVE-2012-2150 xfsprogs: xfs_metadump information disclosure, Debian Bug Tracking System
Next by Date:	Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Christoph Hellwig
Previous by Thread:	[PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Theodore Ts'o
Next by Thread:	[PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Theodore Ts'o
Indexes:	[Date] [Thread] [Top] [All Lists]