xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH v2 2/4] xfsprogs: Don't Make .po files with gettext disabled

from [Christoph Hellwig] [Permanent Link][Original]
To: Jan Tulak <jtulak@xxxxxxxxxx>
Subject: Re: [PATCH v2 2/4] xfsprogs: Don't Make .po files with gettext disabled
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 26 Jul 2015 09:28:49 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1437397018-12864-3-git-send-email-jtulak@xxxxxxxxxx>
References: <1437397018-12864-1-git-send-email-jtulak@xxxxxxxxxx> <1437397018-12864-3-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12) 
On Mon, Jul 20, 2015 at 02:56:56PM +0200, Jan Tulak wrote:
> "po" target is added only if gettext binary is found.
> Without this patch, Make tried to build the target even
> with --enable-gettext=no configure option, which led
> to a failing build.
> 
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH v3] xfsprogs: blkid is now mandatory, Christoph Hellwig
Next by Date:  Re: [PATCH v2 3/4] xfsprogs: Use glibtoolize on osx, Christoph Hellwig
Previous by Thread:  [PATCH v2 2/4] xfsprogs: Don't Make .po files with gettext disabled, Jan Tulak
Next by Thread:  [PATCH v2 4/4] xfsprogs: OS X partial support, Jan Tulak
Indexes:  [Date] [Thread] [Top] [All Lists]