Re: [PATCH] XFS: Delete unnecessary checks before the function call "xfs

To:	SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Subject:	Re: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele"
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 30 Jun 2015 07:43:55 +1000
Cc:	xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<558D1833.3080009@xxxxxxxxxxxxxxxxxxxxx>
References:	<530CD2C4.4050903@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402252117150.2047@xxxxxxxxxxxxxxxxxxxxxxx> <530DD06F.4090703@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402262129250.2221@xxxxxxxxxxxxxxxxxxxxxxx> <5317A59D.4@xxxxxxxxxxxxxxxxxxxxx> <5479F823.60900@xxxxxxxxxxxxxxxxxxxxx> <20141130230904.GF16151@dastard> <558D1833.3080009@xxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

To:

SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Subject:

Re: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele"

From:

Dave Chinner <david@xxxxxxxxxxxxx>

Date:

Tue, 30 Jun 2015 07:43:55 +1000

Cc:

xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx>

Delivered-to:

xfs@xxxxxxxxxxx

In-reply-to:

<558D1833.3080009@xxxxxxxxxxxxxxxxxxxxx>

References:

<530CD2C4.4050903@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402252117150.2047@xxxxxxxxxxxxxxxxxxxxxxx> <530DD06F.4090703@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402262129250.2221@xxxxxxxxxxxxxxxxxxxxxxx> <5317A59D.4@xxxxxxxxxxxxxxxxxxxxx> <5479F823.60900@xxxxxxxxxxxxxxxxxxxxx> <20141130230904.GF16151@dastard> <558D1833.3080009@xxxxxxxxxxxxxxxxxxxxx>

User-agent:

Mutt/1.5.21 (2010-09-15)

On Fri, Jun 26, 2015 at 11:15:31AM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Fri, 26 Jun 2015 11:05:41 +0200
> 
> The xfs_qm_dqrele() function tests whether its argument is NULL and
> then returns immediately.

True.

> Thus the test around the call is not needed.

But wrong.

xfs_dqrele_inode() gets called on every inode in the inode cache,
and this change results in a cacheline in every inode being dirtied
even if they don't have dquots attached. Given the inode cache can
hold tens to hundreds of millions of inodes on large machines, we
don't want to dirty any cachelines we don't need to while walking
the inode cache and releasing dquots...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele", SF Markus Elfring Re: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele", Dave Chinner <=

Previous by Date:	Re: xfs_iext_realloc_indirect and "XFS: possible memory allocation deadlock", Brian Foster
Next by Date:	Re: "Internal error xfs_attr3_leaf_write_verify at line 216", "directory flags set on non-directory inode" and other errors, Dave Chinner
Previous by Thread:	[PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele", SF Markus Elfring
Next by Thread:	We seek Investors and backers - check it out!, Kuddle - The popular photo-sharing App
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

Re: xfs_iext_realloc_indirect and "XFS: possible memory allocation deadlock", Brian Foster

Next by Date:

Re: "Internal error xfs_attr3_leaf_write_verify at line 216", "directory flags set on non-directory inode" and other errors, Dave Chinner

Previous by Thread:

[PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele", SF Markus Elfring

Next by Thread:

We seek Investors and backers - check it out!, Kuddle - The popular photo-sharing App

Indexes:

[Date] [Thread] [Top] [All Lists]