xfs
[Top] [All Lists]

Re: [PATCH 17/17] mkfs: move spinodes crc check

To: Jan ÅulÃk <jtulak@xxxxxxxxxx>
Subject: Re: [PATCH 17/17] mkfs: move spinodes crc check
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 26 Jun 2015 15:32:40 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1434711726-13092-18-git-send-email-jtulak@xxxxxxxxxx>
References: <1434711726-13092-1-git-send-email-jtulak@xxxxxxxxxx> <1434711726-13092-18-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Jun 19, 2015 at 01:02:06PM +0200, Jan ÅulÃk wrote:
> Spinodes crc check is now moved to be in the same way as finobt.
> 
> Signed-off-by: Jan ÅulÃk <jtulak@xxxxxxxxxx>
> ---

Seems fine:

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  mkfs/xfs_mkfs.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 2e455db..653fc5b 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -2347,12 +2347,13 @@ _("32 bit Project IDs always enabled on CRC enabled 
> filesytems\n"));
>  _("warning: finobt not supported without CRC support, disabled.\n"));
>                       sb_feat.finobt = 0;
>               }
> -     }
>  
> -     if (sb_feat.spinodes && !sb_feat.crcs_enabled) {
> -             fprintf(stderr,
> -_("warning: sparse inodes not supported without CRC support, disabled.\n"));
> -             sb_feat.spinodes = 0;
> +             if (sb_feat.spinodes) {
> +                     fprintf(stderr,
> +     _("warning: sparse inodes not supported without CRC support, 
> disabled.\n"));
> +                     sb_feat.spinodes = 0;
> +             }
> +
>       }
>  
>       if (nsflag || nlflag) {
> -- 
> 2.1.0
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>