| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfs: validate transaction header length on log recovery |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 21 Jun 2015 02:27:22 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1434631741-50856-3-git-send-email-bfoster@xxxxxxxxxx> |
| References: | <1434631741-50856-1-git-send-email-bfoster@xxxxxxxxxx> <1434631741-50856-3-git-send-email-bfoster@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
This looks sensible to me, but I still can't make sense of the old code which just conditionally copied it even after taking a brief look at the pre-git history of this code. Does anyone understand why the code was like this? Fixing code that seems to have had an intention I can't make sense of always feel dangerous. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 8/8] xfsprogs: remove xfs_caddr_t, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/2] xfs: validate transaction header length on log recovery, Brian Foster |
| Previous by Thread: | [PATCH 2/2] xfs: validate transaction header length on log recovery, Brian Foster |
| Next by Thread: | Re: [PATCH 2/2] xfs: validate transaction header length on log recovery, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |