xfs
[Top] [All Lists]

Re: [PATCH v2 1/3] xfs_repair: reformat lines to fit within 80 character

To: Mike Grant <mggr@xxxxxxxxx>
Subject: Re: [PATCH v2 1/3] xfs_repair: reformat lines to fit within 80 characters
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 21 Jun 2015 02:16:06 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1434726241-11606-2-git-send-email-mggr@xxxxxxxxx>
References: <1434726241-11606-1-git-send-email-mggr@xxxxxxxxx> <1434726241-11606-2-git-send-email-mggr@xxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Jun 19, 2015 at 04:03:59PM +0100, Mike Grant wrote:
> Also introduces a const to improve readability

Wouldn't just using sizeof(*bplist) be easier?

>  {
>       struct xfs_buf          **bplist;
> +     const size_t            bpsz = sizeof(struct xfs_buf*);

Also if we stay with this version please add a space before the star,
e.g.

        const size_t            bpsz = sizeof(struct xfs_buf *);

<Prev in Thread] Current Thread [Next in Thread>