xfs
[Top] [All Lists]

Re: [PATCH] xfs_metadump: obfuscate remote symlinks on CRC filesystems

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_metadump: obfuscate remote symlinks on CRC filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 21 Jun 2015 02:14:19 -0700
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <55847BE8.8010908@xxxxxxxxxx>
References: <55847BE8.8010908@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Jun 19, 2015 at 03:30:32PM -0500, Eric Sandeen wrote:
> On CRC filesystems, the symlink block starts with a header,
> which contains magic, "XLSM"
> 
> The code happens to "work" today w/o corrupting anything,
> because it seems "XSLM" as a string, decides it's too short
> to obfuscate, and leaves it alone.
> 
> But the real symlink target is untouched.  Fix that by moving
> the pointer to the string we want to obfuscate by the size
> of the header, and shorten the length to obfuscate accordingly.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Any chance to get a test for this into xfstests?

<Prev in Thread] Current Thread [Next in Thread>