Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing

xfs

Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing

To:	Jan Tulak <jtulak@xxxxxxxxxx>
Subject:	Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 19 Jun 2015 08:09:04 -0700
Cc:	Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<14667996.16447259.1434625419793.JavaMail.zimbra@xxxxxxxxxx>
References:	<55820229.1010701@xxxxxxxxxx> <14667996.16447259.1434625419793.JavaMail.zimbra@xxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Thu, Jun 18, 2015 at 07:03:39AM -0400, Jan Tulak wrote:
> This changes get_topology only for ENABLE_BLKID branch of #ifdef. Is that 
> intentional, i.e. we don't expect anyone not using ENABLE_BLKID? Because 
> otherwise, if mkfs is compiled without ENABLE_BLKID, then all we get is:

I'm in favor of killing the !ENABLE_BLKID entirely.  The proper
support in blkid has been around long enough to require it.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Jan Tulak Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Jan Tulak Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Christoph Hellwig <= Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Christoph Hellwig Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen PATCH V2] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen

Previous by Date:	Re: [PATCH] xfs_copy: fix copy of hard 4k devices, Christoph Hellwig
Next by Date:	Re: [PATCH 1/2] xfs: don't truncate attribute extents if no extents exist, Christoph Hellwig
Previous by Thread:	Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Jan Tulak
Next by Thread:	Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]