xfs
[Top] [All Lists]

[PATCH v2 0/3] clear new memory after realloc

To: <xfs@xxxxxxxxxxx>
Subject: [PATCH v2 0/3] clear new memory after realloc
From: Mike Grant <mggr@xxxxxxxxx>
Date: Fri, 19 Jun 2015 16:03:58 +0100
Cc: Mike Grant <mggr@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
v2
 - updated indentation per Brian Foster's suggestions
 - added a patch to correct the finalisation of the potentially-realloc'ed
   bplist, following IRC discussion with Brian

This patchset fixes the seg-fault bug that was crashing an xfs_repair attempt
on a 150TB filesystem.  The problem, including traces and metadump link, is
in the mail thread "xfs_repair segfault + debug info" 29/May/2015.  After the
patch was applied, the xfs_repair ran through to completion.

The final for loops at the end of the function containing the realloc didn't
account for any extra buffers that might have been added; this is corrected.

A cosmetic reformatting of nearby lines is included, using a constant to reduce
line lengths.


Mike Grant (3):
  xfs_repair: reformat lines to fit within 80 characters
  xfs_repair: clear new memory after realloc
  xfs_repair: include any realloc'ed buffers in final putbuf

 repair/phase6.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

-- 
2.1.0

(apologies for the following junk forcibly appended by my company)


Please visit our new website at www.pml.ac.uk and follow us on Twitter  
@PlymouthMarine

Winner of the Environment & Conservation category, the Charity Awards 2014.

Plymouth Marine Laboratory (PML) is a company limited by guarantee registered 
in England & Wales, company number 4178503. Registered Charity No. 1091222. 
Registered Office: Prospect Place, The Hoe, Plymouth  PL1 3DH, UK. 

This message is private and confidential. If you have received this message in 
error, please notify the sender and remove it from your system. You are 
reminded that e-mail communications are not secure and may contain viruses; PML 
accepts no liability for any loss or damage which may be caused by viruses.

<Prev in Thread] Current Thread [Next in Thread>