xfs
[Top] [All Lists]

Re: [PATCH] xfs_copy: fix copy of hard 4k devices

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_copy: fix copy of hard 4k devices
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 19 Jun 2015 09:19:46 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5581C962.7020200@xxxxxxxxxx>
References: <5581C962.7020200@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Jun 17, 2015 at 02:24:18PM -0500, Eric Sandeen wrote:
> If we have a pure 4k device with no 512 emulation, xfs_copy
> fails straightaway because it tries to do a 512-byte direct
> IO read of the superblock.
> 
> Do like we do in xfs_db, and read in the max possible sector size,
> because we don't yet know what the filesystem's sector size is.
> 
> This fixes a failure in xfs/032 on a hard 4k device.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> 
> diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
> index 279527c..b39c84d 100644
> --- a/copy/xfs_copy.c
> +++ b/copy/xfs_copy.c
> @@ -654,8 +654,9 @@ main(int argc, char **argv)
>  
>       memset(&mbuf, 0, sizeof(xfs_mount_t));
>       libxfs_buftarg_init(&mbuf, xargs.ddev, xargs.logdev, xargs.rtdev);
> -     sbp = libxfs_readbuf(mbuf.m_ddev_targp, XFS_SB_DADDR, 1, 0,
> -                                                     &xfs_sb_buf_ops);
> +     sbp = libxfs_readbuf(mbuf.m_ddev_targp, XFS_SB_DADDR,
> +                          1 << (XFS_MAX_SECTORSIZE_LOG - BBSHIFT),
> +                          0, &xfs_sb_buf_ops);
>       sb = &mbuf.m_sb;
>       libxfs_sb_from_disk(sb, XFS_BUF_TO_SBP(sbp));
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>