xfs
[Top] [All Lists]

[PATCH] xfs: fix remote symlinks on V5/CRC filesystems

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfs: fix remote symlinks on V5/CRC filesystems
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Mon, 15 Jun 2015 17:13:50 -0500
Delivered-to: xfs@xxxxxxxxxxx
If we create a CRC filesystem, mount it, and create a symlink with
a path long enough that it can't live in the inode, we get a very
strange result upon remount:

# ls -l mnt
total 4
lrwxrwxrwx. 1 root root 929 Jun 15 16:58 link -> XSLM

XSLM is the V5 symlink block header magic (which happens to be
followed by a NUL, so the string looks terminated).

xfs_readlink_bmap() advanced cur_chunk by the size of the header
for CRC filesystems, but never actually used that pointer; it
kept reading from bp->b_addr, which is the start of the block,
rather than the start of the symlink data after the header.

Looks like this problem goes back to v3.10.

Fixing this gets us reading the proper link target, again.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
---

diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c
index 3df411e..40c0765 100644
--- a/fs/xfs/xfs_symlink.c
+++ b/fs/xfs/xfs_symlink.c
@@ -104,7 +104,7 @@ xfs_readlink_bmap(
                        cur_chunk += sizeof(struct xfs_dsymlink_hdr);
                }
 
-               memcpy(link + offset, bp->b_addr, byte_cnt);
+               memcpy(link + offset, cur_chunk, byte_cnt);
 
                pathlen -= byte_cnt;
                offset += byte_cnt;

<Prev in Thread] Current Thread [Next in Thread>