xfs
[Top] [All Lists]

[PATCH 1/4] xfsprogs: remove unused write-only var l_logsize

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: [PATCH 1/4] xfsprogs: remove unused write-only var l_logsize
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 29 May 2015 14:03:37 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5568B7CE.9030709@xxxxxxxxxx>
References: <5568B7CE.9030709@xxxxxxxxxx>
l_logsize is only ever set, and is never read.
Remove it.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
 db/sb.c             |    1 -
 include/libxlog.h   |    1 -
 logprint/logprint.c |    1 -
 repair/phase2.c     |    1 -
 4 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/db/sb.c b/db/sb.c
index cd12f83..991478d 100644
--- a/db/sb.c
+++ b/db/sb.c
@@ -251,7 +251,6 @@ sb_logcheck(void)
                x.lbsize <<= (mp->m_sb.sb_logsectlog - BBSHIFT);
 
        log.l_dev = mp->m_logdev_targp;
-       log.l_logsize = BBTOB(log.l_logBBsize);
        log.l_logBBsize = x.logBBsize;
        log.l_logBBstart = x.logBBstart;
        log.l_sectBBsize  = BTOBB(x.lbsize);
diff --git a/include/libxlog.h b/include/libxlog.h
index d6ba9a5..e6d915c 100644
--- a/include/libxlog.h
+++ b/include/libxlog.h
@@ -28,7 +28,6 @@ struct xlog {
        xfs_mount_t     *l_mp;          /* mount point */
        struct xfs_buftarg *l_dev;              /* dev_t of log */
        xfs_daddr_t     l_logBBstart;   /* start block of log */
-       int             l_logsize;      /* size of log in bytes */
        int             l_logBBsize;    /* size of log in 512 byte chunks */
        int             l_curr_cycle;   /* Cycle number of log writes */
        int             l_prev_cycle;   /* Cycle # b4 last block increment */
diff --git a/logprint/logprint.c b/logprint/logprint.c
index 960a267..fdf106b 100644
--- a/logprint/logprint.c
+++ b/logprint/logprint.c
@@ -242,7 +242,6 @@ main(int argc, char **argv)
        ASSERT(x.logBBsize <= INT_MAX);
 
        log.l_dev = mount.m_logdev_targp;
-       log.l_logsize     = BBTOB(x.logBBsize);
        log.l_logBBstart  = x.logBBstart;
        log.l_logBBsize   = x.logBBsize;
        log.l_sectBBsize  = BTOBB(x.lbsize);
diff --git a/repair/phase2.c b/repair/phase2.c
index 0192346..983aaa7 100644
--- a/repair/phase2.c
+++ b/repair/phase2.c
@@ -50,7 +50,6 @@ zero_log(xfs_mount_t *mp)
                x.lbsize <<= (mp->m_sb.sb_logsectlog - BBSHIFT);
 
        log.l_dev = mp->m_logdev_targp;
-       log.l_logsize = BBTOB(x.logBBsize);
        log.l_logBBsize = x.logBBsize;
        log.l_logBBstart = x.logBBstart;
        log.l_sectBBsize  = BTOBB(x.lbsize);
-- 1.7.1

<Prev in Thread] Current Thread [Next in Thread>