xfs
[Top] [All Lists]

Re: [PATCH v2 1/5] xfs_repair: refuse to run if we don't recognize versi

To: Fanael Linithien <fanael4@xxxxxxxxx>, "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, david@xxxxxxxxxxxxx
Subject: Re: [PATCH v2 1/5] xfs_repair: refuse to run if we don't recognize version or feature flags
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 27 May 2015 11:26:55 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5565EB29.4080200@xxxxxxxxx>
References: <20150526225126.26434.69010.stgit@xxxxxxxxxxxxxxxx> <20150526225132.26434.82404.stgit@xxxxxxxxxxxxxxxx> <20150527054536.GB10175@xxxxxxxxxxxxxxxx> <5565DAA7.4040406@xxxxxxxxxxx> <5565DFEB.9040000@xxxxxxxxxxx> <5565E265.5040202@xxxxxxxxxxx> <5565EB29.4080200@xxxxxxxxx>
On 5/27/15 11:04 AM, Fanael Linithien wrote:
> I'm not entirely sure silently ignoring unknown compat features in
> xfs_repair is a good idea. Consider this ext2 example: xattr support
> is a compat flag. It's okay to rw mount a FS with xattrs on some
> ancient (or non-Linux) kernel without xattr support — everything will
> be fine, even though there's no way to access them — but if the fsck
> tool doesn't understand them, it wouldn't be able to diagnose xattr
> corruption.

Hm, good point.  We have no "compat" features atm, so it's not really clear;
if nothing else, though, those features will have to go un-checked, if there
is any checking to do.  So yeah, maybe best to keep it as an exclusion.

-Eric

<Prev in Thread] Current Thread [Next in Thread>