xfs
[Top] [All Lists]

Re: [PATCH v2 1/5] xfs_repair: refuse to run if we don't recognize versi

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, david@xxxxxxxxxxxxx
Subject: Re: [PATCH v2 1/5] xfs_repair: refuse to run if we don't recognize version or feature flags
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 27 May 2015 10:16:59 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5565DAA7.4040406@xxxxxxxxxxx>
References: <20150526225126.26434.69010.stgit@xxxxxxxxxxxxxxxx> <20150526225132.26434.82404.stgit@xxxxxxxxxxxxxxxx> <20150527054536.GB10175@xxxxxxxxxxxxxxxx> <5565DAA7.4040406@xxxxxxxxxxx>
On 5/27/15 9:54 AM, Eric Sandeen wrote:
> On 5/27/15 12:45 AM, Darrick J. Wong wrote:
>> Apparently xfs_repair running on a v5 filesystem doesn't check the
>> compat, rocompat, or incompat feature flags for bits that it doesn't
>> know about, which means that old xfs_repairs can wreak havoc.  So,
>> strengthen the checks to prevent repair from "repairing" anything it
>> doesn't understand.
>>
>> v2: Move the complaint code after the version number check, and print
>> the actual feature bits that we don't recognize.
> 
> Thanks.  That's a bit more wordy, but probably better, in the end.
> 
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Whoops, retract that, thanks for spotting those C&P errors, Fanael!

-Eric

<Prev in Thread] Current Thread [Next in Thread>