On Tue, May 26, 2015 at 06:07:32PM -0500, Eric Sandeen wrote:
> On 5/26/15 5:51 PM, Darrick J. Wong wrote:
> > Plumb in the necessary magic number checks and other fixups required
> > to handle v5 filesystems.
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > @@ -799,8 +803,6 @@ blockget_f(
> > * filters out, or we need to actually do the work to make check support
> > * crc enabled filesystems.
> > */
> > - if (xfs_sb_version_hascrc(&mp->m_sb))
> > - return 0;
> Hm, the comment above these lines says:
> * XXX: check does not support CRC enabled filesystems. Return
> * immediately, silently, with success but without doing anything
> * initially so that xfstests can run without modification on metadata
> * enabled filesystems.
> * XXX: ultimately we need to dump an error message here that xfstests
> * filters out, or we need to actually do the work to make check
> * crc enabled filesystems.
> but now we don't. So I guess the comment should go too?
> I guess check is deprecated now, so the comment is stale anyway...
Doh. Forgot to remove that. Will resend.