xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs_db: enable blockget for v5 filesystems

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs_db: enable blockget for v5 filesystems
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Tue, 26 May 2015 16:13:35 -0700
Cc: david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5564FCB4.6070603@xxxxxxxxxxx>
References: <20150526225126.26434.69010.stgit@xxxxxxxxxxxxxxxx> <20150526225153.26434.96347.stgit@xxxxxxxxxxxxxxxx> <5564FCB4.6070603@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 26, 2015 at 06:07:32PM -0500, Eric Sandeen wrote:
> On 5/26/15 5:51 PM, Darrick J. Wong wrote:
> > Plumb in the necessary magic number checks and other fixups required
> > to handle v5 filesystems.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> > @@ -799,8 +803,6 @@ blockget_f(
> >      * filters out, or we need to actually do the work to make check support
> >      * crc enabled filesystems.
> >      */
> > -   if (xfs_sb_version_hascrc(&mp->m_sb))
> > -           return 0;
> 
> Hm, the comment above these lines says:
> 
>         /*
>          * XXX: check does not support CRC enabled filesystems. Return
>          * immediately, silently, with success but  without doing anything 
> here
>          * initially so that xfstests can run without modification on metadata
>          * enabled filesystems.
>          *
>          * XXX: ultimately we need to dump an error message here that xfstests
>          * filters out, or we need to actually do the work to make check 
> support
>          * crc enabled filesystems.
>          */
> 
> but now we don't.  So I guess the comment should go too?
> 
> I guess check is deprecated now, so the comment is stale anyway...

Doh.  Forgot to remove that.  Will resend.

--D

>   
> -Eric
> 

<Prev in Thread] Current Thread [Next in Thread>