xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs_db: enable blockget for v5 filesystems

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, david@xxxxxxxxxxxxx
Subject: Re: [PATCH 4/5] xfs_db: enable blockget for v5 filesystems
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 26 May 2015 18:07:32 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150526225153.26434.96347.stgit@xxxxxxxxxxxxxxxx>
References: <20150526225126.26434.69010.stgit@xxxxxxxxxxxxxxxx> <20150526225153.26434.96347.stgit@xxxxxxxxxxxxxxxx>
On 5/26/15 5:51 PM, Darrick J. Wong wrote:
> Plumb in the necessary magic number checks and other fixups required
> to handle v5 filesystems.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

> @@ -799,8 +803,6 @@ blockget_f(
>        * filters out, or we need to actually do the work to make check support
>        * crc enabled filesystems.
>        */
> -     if (xfs_sb_version_hascrc(&mp->m_sb))
> -             return 0;

Hm, the comment above these lines says:

        /*
         * XXX: check does not support CRC enabled filesystems. Return
         * immediately, silently, with success but  without doing anything here
         * initially so that xfstests can run without modification on metadata
         * enabled filesystems.
         *
         * XXX: ultimately we need to dump an error message here that xfstests
         * filters out, or we need to actually do the work to make check support
         * crc enabled filesystems.
         */

but now we don't.  So I guess the comment should go too?

I guess check is deprecated now, so the comment is stale anyway...
  
-Eric

<Prev in Thread] Current Thread [Next in Thread>