xfs
[Top] [All Lists]

Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

To: Fabian Frederick <fabf@xxxxxxxxx>
Subject: Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Mon, 18 May 2015 18:19:46 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1431969231-12834-1-git-send-email-fabf@xxxxxxxxx>
References: <1431969231-12834-1-git-send-email-fabf@xxxxxxxxx>
Sender: Al Viro <viro@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote:
>        * If the block order is wrong, swap the arguments.
>        */
> -     if ((swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp))) {
> -             xfs_da_state_blk_t      *tmp;   /* temp for block swap */
> +     swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp);
> +     if (swap)
> +             swap(blk1, blk2);

Egads...  Have you even read what you'd written?  Yes, sure, preprocessor
will do the right thing, but it's a very noticable annoyance for somebody
reading that.  Rename the bleeding flag, please.

<Prev in Thread] Current Thread [Next in Thread>