xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: properly detect reserved attribute names

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: properly detect reserved attribute names
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu, 14 May 2015 10:05:42 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Zach Brown <zab@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150514142210.GC23683@xxxxxxxxxxxxxxx>
References: <555416A6.4020401@xxxxxxxxxx> <20150514142210.GC23683@xxxxxxxxxxxxxxx>
On 5/14/15 9:22 AM, Brian Foster wrote:
> On Wed, May 13, 2015 at 10:29:42PM -0500, Eric Sandeen wrote:
>> This function in xfs_repair tries to make sure that if an attr
>> name reserved for acls exists in the root namespace, then its
>> value is a valid acl.
>>
>> However, because it only compares up to the length of the
>> reserved name, superstrings may match and cause false positive
>> xfs_repair errors.
>>
>> Ensure that both the length and the content match before
>> flagging it as an error.
>>
>> Spotted-by: Zach Brown <zab@xxxxxxxxx>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>> ---
> 
> Looks good:
> 
> Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
> 
> So it looks like master doesn't have the sizeof(unsigned char *)
> problem and the 4.1 update branch does, so we want to make sure that
> kernel fix makes it into the latter...

Yep.  This fix is needed independently of that, though.

Thanks!
-Eric

<Prev in Thread] Current Thread [Next in Thread>