xfs
[Top] [All Lists]

Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compar

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare()
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Wed, 13 May 2015 09:59:19 -0400
Cc: xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=nAL2kqQ/mgCqDcfSw4NXqxNvsOZeaNYar907tMSLchM=; b=PgjOlydBbQxg1HFWS7XVONIE7hJPYKuG0XkuTwzxSBluqdtnXWV1N9qoykRW2j2Nay FQk7Mv/nJokZKvivbhx1HOWfvwB6wW+B8mjCukzdEXlnlIIUISFPE56fs4xuS58xP47m NjuZE7o8HB9FfbdsLPziZclrJSlnIzkFOicKTfA4WgyHChDzEV3UUwisps1DOn/9F+L+ cvAM9AawhFYVmKLv5vqbQB1AhzZBoD6D6DxJqABxFB3xT0bfGAEJn+Gz0WqW9OmN8J92 kT1nDQXGw7ZUd/NEGFaVP3OrVc24Rq17lipdAvjLwQin0pR3ZC66J1NZ/WuJ+dFc/8Ez ZcGQ==
In-reply-to: <1431474754-15764-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1431474754-15764-1-git-send-email-david@xxxxxxxxxxxxx> <1431474754-15764-2-git-send-email-david@xxxxxxxxxxxxx>
Sender: Tejun Heo <htejun@xxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
Hello, Dave.

On Wed, May 13, 2015 at 09:52:33AM +1000, Dave Chinner wrote:
> @@ -116,6 +121,12 @@ static inline int percpu_counter_compare(struct 
> percpu_counter *fbc, s64 rhs)
>               return 0;
>  }
>  
> +static inline int
> +percpu_counter_compare(struct percpu_counter *fbc, s64 rhs, s32 batch)
> +{
> +     return percpu_counter_compare(fbc, rhs);
> +}

I don't think this is right.  Looks fine to me otherwise.

Thanks.

-- 
tejun

<Prev in Thread] Current Thread [Next in Thread>