xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs: saner xfs_trans_commit interface

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs: saner xfs_trans_commit interface
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 12 May 2015 08:36:32 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150511203237.GA59885@xxxxxxxxxxxxxxx>
References: <1431285519-7768-1-git-send-email-hch@xxxxxx> <1431285519-7768-4-git-send-email-hch@xxxxxx> <20150511203237.GA59885@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, May 11, 2015 at 04:32:37PM -0400, Brian Foster wrote:
> >     xfs_trans_unreserve_and_mod_dquots(tp);
> >     if (tp->t_ticket) {
> > +           int                     log_flags = 0;
> > +
> > +           if (regrant) {
> > +                   ASSERT(tp->t_flags & XFS_TRANS_PERM_LOG_RES);
> > +                   log_flags = XFS_LOG_REL_PERM_RESERV;
> > +           }
> 
> Is the regrant logic here and in xfs_log_commit_cil() backwards or am I
> misreading?

Yes, it's actually wrong, but fixed up by the next patch.

I'll wait for more review feedback and will resend a fixed version.

p.s. can you please properly quote when replying?  I had to trim over 600 lines
to get to your two line comment..

<Prev in Thread] Current Thread [Next in Thread>