[Top] [All Lists]

Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compar

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 6 May 2015 15:43:10 +1000
Cc: xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150506043636.GA10940@xxxxxxxxxxxxx>
References: <1430863299-9341-1-git-send-email-david@xxxxxxxxxxxxx> <1430863299-9341-2-git-send-email-david@xxxxxxxxxxxxx> <20150506043636.GA10940@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 05, 2015 at 09:36:36PM -0700, Christoph Hellwig wrote:
> This looks reasonable, but I miss Ccs to the authors of the
> percpu_counter code and linux-kernel.

linux-kernel was cc'd.

> On Wed, May 06, 2015 at 08:01:38AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> And this looks wrong, too :)

That looks like a change of tool behaviour. I just upgraded guilt;
the old version stripped "from" lines in patch descriptions from the
git commit log as goes into the author field of the commit. The new
version does not appear to strip the from lines, and so when
git-send-email formats it, it puts a from line in the message, and
then the commit message has one too.

Thanks for pointing it out.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>