xfs
[Top] [All Lists]

Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static
From: nick <xerofoify@xxxxxxxxx>
Date: Tue, 05 May 2015 18:16:22 -0400
Cc: xfs@xxxxxxxxxxx, bfoster@xxxxxxxxxx, sandeen@xxxxxxxxxxx, hch@xxxxxx, jack@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=qiaMK3cgiSRH6skCErB8iTqEH582fEvB6ZOa/bFAktU=; b=sn4KYX75JESAx+6J0m/yJHcuo6NibAfGfe03ejtO+NZsmicPCQFM2sIZtRCOKzTs2j e5xkQXj36zLvKwe+c+ATEFrw2JV6ZwXHkVCqrcJkAv8VYGDIm6kVFmNnnndQCmfiGKJ3 PXjEhpg6b5znWRKfgKrfUUCtimgFg+UPVckXqDyflUyqZ4we3HSvLN1VoQt1ZToGonF4 RoAAA99IRfe9r1EN2C+rpWivy1BCsL6m/ir1I/DA81xbesSDVh7o1xd+6K5Mbi/M/J3p 8DpiK8LEHF5ovML54IR+4zX22q0kbdyaDwBNErW81pOKXNq2ut64eKc9Gk+xjn0LCSpe SreA==
In-reply-to: <20150505221209.GG21261@dastard>
References: <1430856999-31952-1-git-send-email-xerofoify@xxxxxxxxx> <20150505221209.GG21261@dastard>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 2015-05-05 06:12 PM, Dave Chinner wrote:
> On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote:
>> This makes the function,xfs_alloc_lookup_eq static as there are no
>> calls to this function outside the definition file for this function,
>> xfs_alloc.c.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>> ---
>>  fs/xfs/libxfs/xfs_alloc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
>> index 516162b..48de3f0 100644
>> --- a/fs/xfs/libxfs/xfs_alloc.c
>> +++ b/fs/xfs/libxfs/xfs_alloc.c
>> @@ -52,7 +52,7 @@ STATIC int xfs_alloc_ag_vextent_small(xfs_alloc_arg_t *,
>>  /*
>>   * Lookup the record equal to [bno, len] in the btree given by cur.
>>   */
>> -STATIC int                          /* error */
>> +static int                          /* error */
>>  xfs_alloc_lookup_eq(
>>      struct xfs_btree_cur    *cur,   /* btree cursor */
>>      xfs_agblock_t           bno,    /* starting block of extent */
> 
> Please have a look at what STATIC actually means, and then use the
> sparse checker to confirm that these functions are already static
> for a CONFIG_XFS_DEBUG=n build.
> 
> i.e. STATIC is a stack usage minimisation and debugging aid, not
> something that is broken and needs fixing.
> 
> Cheers,
> 
> Dave.
> 
That's Ok I wasn't sure if that was there for those reasons.Next time 
I will be more careful and check out the macros I don't known. :(
Sorry,
Nick 

<Prev in Thread] Current Thread [Next in Thread>