Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache

To:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject:	Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache
From:	Christoph Hellwig <hch@xxxxxx>
Date:	Sat, 25 Apr 2015 20:32:47 +0200
Cc:	Christoph Hellwig <hch@xxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20150425145728.GE889@xxxxxxxxxxxxxxxxxx>
References:	<1429816064-10033-1-git-send-email-hch@xxxxxx> <1429816064-10033-6-git-send-email-hch@xxxxxx> <20150423222942.GK15810@dastard> <20150425141612.GA4153@xxxxxx> <20150425145728.GE889@xxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.17 (2007-11-01)

On Sat, Apr 25, 2015 at 03:57:28PM +0100, Al Viro wrote:
> > Note that caching the symlink in a kmalloc'ed buffer might be
> > more efficient than the pagecache for most cases anyway.
> 
> Hmm...  When would you free the sucker?

final iput.  Similar design to the generic ACL cache.

<Prev in Thread]	Current Thread	[Next in Thread>
optimize symlink handling, Christoph Hellwig [PATCH 2/6] xfs: factor out a helper to initialize a local format inode fork, Christoph Hellwig [PATCH 4/6] xfs: use ->readlink to implement the readlink_by_handle ioctl, Christoph Hellwig [PATCH 3/6] xfs: set up inode operation vectors later, Christoph Hellwig [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Christoph Hellwig Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Dave Chinner Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Christoph Hellwig Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Christoph Hellwig Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Al Viro Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Al Viro Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Christoph Hellwig <= Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Al Viro [PATCH 6/6] xfs: optimize inline symlinks, Christoph Hellwig

Previous by Date:	Attn: xfs---Reduce the cost in office supply, Linda
Next by Date:	donation for you, click reply for more info, Quan (Le Hoang Quan)
Previous by Thread:	Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Al Viro
Next by Thread:	Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Al Viro
Indexes:	[Date] [Thread] [Top] [All Lists]