[Top] [All Lists]

Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 24 Apr 2015 10:21:12 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150423222942.GK15810@dastard>
References: <1429816064-10033-1-git-send-email-hch@xxxxxx> <1429816064-10033-6-git-send-email-hch@xxxxxx> <20150423222942.GK15810@dastard>
User-agent: Mutt/1.5.17 (2007-11-01)
On Fri, Apr 24, 2015 at 08:29:42AM +1000, Dave Chinner wrote:
> On Thu, Apr 23, 2015 at 09:07:43PM +0200, Christoph Hellwig wrote:
> > We can use the generic symlink in pagecache code for XFS non-inline
> > symlinks.  Because links are always shorter than a page we will
> > get the zero termination for the link for free.
> Doesn't work for v5 filesystems where headers and CRCs are embedded
> into the same blocks as the symlink data. i.e. this now falls down
> to ->readpage to read the link data into the page cache, and that
> just reads the entire blocks into the page cache. So what we can end
> up within the page cache is this:

Uh, ok.  Guess the pagecache symlink support isn't too useful then.
I'll respin to only optimize the inline symlinks, which should
still we worthwhile.

<Prev in Thread] Current Thread [Next in Thread>