xfs
[Top] [All Lists]

Re: [PATCH] xfs: don't trigger fsync log force based on inode pin count

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: don't trigger fsync log force based on inode pin count
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 22 Apr 2015 09:15:09 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1429713466-22137-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1429713466-22137-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Apr 22, 2015 at 10:37:46AM -0400, Brian Foster wrote:
> There are probably a couple different ways to handle this. We could log
> the inode in the bmap cases in order to preserve the pincount check.

I'd favor that.  For one performance should be better, second we really
need to dirty the inode anyway for v5 file systems as that's the
mechanism used to increment di_changecount.

<Prev in Thread] Current Thread [Next in Thread>