xfs
[Top] [All Lists]

[PATCH] xfs: xfs_iozero can return positive errno

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: xfs_iozero can return positive errno
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 16 Apr 2015 22:38:41 +1000
Delivered-to: xfs@xxxxxxxxxxx
From: Dave Chinner <dchinner@xxxxxxxxxx>

It was missed when we converted everything in XFs to use negative error
numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
error sign conversion"), and should go back to stable kernels.

Thanks to Brian Foster for noticing it.

cc: <stable@xxxxxxxxxxxxxxx> # 3.17, 3.18, 3.19, 4.0
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 fs/xfs/xfs_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index ec0c9c2..8383df0 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -125,7 +125,7 @@ xfs_iozero(
                status = 0;
        } while (count);
 
-       return (-status);
+       return status;
 }
 
 int
-- 
2.0.0

<Prev in Thread] Current Thread [Next in Thread>