xfs
[Top] [All Lists]

Re: [PATCH] xfs: unlock i_mutex in xfs_break_layouts

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: unlock i_mutex in xfs_break_layouts
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 8 Apr 2015 18:21:04 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150407210747.GD3363@xxxxxxxxxxxx>
References: <1428420944-20965-1-git-send-email-hch@xxxxxx> <20150407210747.GD3363@xxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Tue, Apr 07, 2015 at 05:07:47PM -0400, J. Bruce Fields wrote:
> On Tue, Apr 07, 2015 at 05:35:44PM +0200, Christoph Hellwig wrote:
> > We want to drop all I/O path locks when recalling layouts, and that includes
> > i_mutex for the write path.  Without this we get stuck processe when recalls
> > take too long.
> 
> Also if the writer is an nfsd thread than we'd rather just error out
> than wait.

We have no way to know we are called by nfsd here unfortunately.

<Prev in Thread] Current Thread [Next in Thread>