xfs
[Top] [All Lists]

Re: [RFC 1/2] xfs_db: enable blockget for v5 filesystems

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [RFC 1/2] xfs_db: enable blockget for v5 filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 7 Apr 2015 10:03:03 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150318232356.GC24608@xxxxxxxxxxxxxxxx>
References: <20150318232356.GC24608@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 18, 2015 at 04:23:56PM -0700, Darrick J. Wong wrote:
> Plumb in the necessary magic number checks and other fixups required
> to handle v5 filesystems.  This requires Eric Sandeen's earlier patch
> rollup.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
>  db/check.c |   52 +++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 39 insertions(+), 13 deletions(-)
> 
> diff --git a/db/check.c b/db/check.c
> index 4fd9fd0..767022f 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -799,8 +799,6 @@ blockget_f(
>        * filters out, or we need to actually do the work to make check support
>        * crc enabled filesystems.
>        */
> -     if (xfs_sb_version_hascrc(&mp->m_sb))
> -             return 0;

This causes check to run from xfstests on v5 filesystems, which then
throws errors everywhere and fails every test. A more nuanced
enablement of blockget is required here....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [RFC 1/2] xfs_db: enable blockget for v5 filesystems, Dave Chinner <=