Re: [RFC 1/2] xfs_db: enable blockget for v5 filesystems

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Wed, Mar 18, 2015 at 04:23:56PM -0700, Darrick J. Wong wrote:
> Plumb in the necessary magic number checks and other fixups required
> to handle v5 filesystems.  This requires Eric Sandeen's earlier patch
> rollup.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
>  db/check.c |   52 +++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 39 insertions(+), 13 deletions(-)
> 
> diff --git a/db/check.c b/db/check.c
> index 4fd9fd0..767022f 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -799,8 +799,6 @@ blockget_f(
>        * filters out, or we need to actually do the work to make check support
>        * crc enabled filesystems.
>        */
> -     if (xfs_sb_version_hascrc(&mp->m_sb))
> -             return 0;

This causes check to run from xfstests on v5 filesystems, which then
throws errors everywhere and fails every test. A more nuanced
enablement of blockget is required here....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx