xfs
[Top] [All Lists]

Re: [PATCH] xfs: disallow ro->rw remount on norecovery mount

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: disallow ro->rw remount on norecovery mount
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 27 Mar 2015 07:59:58 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <55146612.1070306@xxxxxxxxxx>
References: <55146612.1070306@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 26, 2015 at 03:03:30PM -0500, Eric Sandeen wrote:
> There's a bit of a loophole in norecovery mount handling right
> now: an initial mount must be readonly, but nothing prevents
> a mount -o remount,rw from producing a writable, unrecovered
> xfs filesystem.
> 
> It might be possible to try to perform a log recovery when this
> is requested, but I'm not sure it's worth the effort.  For now,
> simply disallow this sort of transition.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Good catch.

Shouldn't this also check for a ro block device, and disallow the
rw remount if the block dev is ro?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>