xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: pass attr geometry to attr leaf header conversion f

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: pass attr geometry to attr leaf header conversion functions
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 26 Mar 2015 07:51:52 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1424811024-24839-2-git-send-email-bfoster@xxxxxxxxxx>
References: <1424811024-24839-1-git-send-email-bfoster@xxxxxxxxxx> <1424811024-24839-2-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 24, 2015 at 03:50:23PM -0500, Brian Foster wrote:
> The firstused field of the xfs_attr3_leaf_hdr structure is subject to an
> overflow when fs blocksize is 64k. In preparation to handle this
> overflow in the header conversion functions, pass the attribute geometry
> to the functions that convert the in-core structure to and from the
> on-disk structure.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Hmmm. not sure I'm a great fan of this, but let's see.

Ok, this just a conversion patch, moving on to the second patch...

-Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 1/2] xfs: pass attr geometry to attr leaf header conversion functions, Dave Chinner <=