xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfs: factor out xfs_rename_finish()

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: factor out xfs_rename_finish()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2015 08:27:18 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5511D166.7050201@xxxxxxxxxxx>
References: <1427194771-3105-1-git-send-email-david@xxxxxxxxxxxxx> <1427194771-3105-4-git-send-email-david@xxxxxxxxxxxxx> <5511D166.7050201@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 24, 2015 at 04:04:38PM -0500, Eric Sandeen wrote:
> On 3/24/15 5:59 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Rather than use a jump label for the final transaction commit in
> > the rename, factor it into a simple helper function and call it
> > appropriately. This slightly reduces the spaghetti nature of
> > xfs_rename.
> 
> Nit, subject should be "xfs_finish_rename" not "xfs_rename_finish"

Will fix.

-Dave
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>