xfs
[Top] [All Lists]

Re: [PATCH 0/5 V2] xfs: RENAME_WHITEOUT support

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 0/5 V2] xfs: RENAME_WHITEOUT support
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 24 Mar 2015 16:12:17 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1427194771-3105-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1427194771-3105-1-git-send-email-david@xxxxxxxxxxxxx>
On 3/24/15 5:59 AM, Dave Chinner wrote:
> Hi folks,
> 
> This is the second version of the RENAME_WHITEOUT patchset that I
> originally posted here:
> 
> http://oss.sgi.com/pipermail/xfs/2015-February/040378.html
> 
> This is mainly the breakup and restructuring of the patchset I
> mention that needed to be done, as well as addressing the comments
> that were made at the time (e.g. wino -> wip).
> 
> The patchset has been split into 5 patches, the first four are
> really cleanup and factoring patches to make the rename and inode
> locking code a bit simpler and easier to understand. The last patch
> then introduces the RENAME_WHITEOUT functionality, which ends up
> being surprisingly little code....
> 
> The changes pass xfstests, but I have not run them on overlayfs at
> all yet, so I don't know if that's going to result in smoke and
> tears yet. Still, getting the patch set out for review now is more
> important that waiting for testing because there is relatively
> little time left before the 4.1 merge window opens up....
> 
> So, comments, thoughts and flames are more than welcome.

I mentioned little editorial nits on patches 3 and 5, otherwise looks fine;
fix them or not, you can add:

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>