[Top] [All Lists]

Re: [PATCH 5/8] xfs: add DAX file operations support

To: Boaz Harrosh <boaz@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 5/8] xfs: add DAX file operations support
From: Boaz Harrosh <boaz@xxxxxxxxxxxxx>
Date: Tue, 24 Mar 2015 14:24:22 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, willy@xxxxxxxxxxxxxxx, jack@xxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <551153C4.6000808@xxxxxxxxxxxxx>
References: <1427194266-2885-1-git-send-email-david@xxxxxxxxxxxxx> <1427194266-2885-6-git-send-email-david@xxxxxxxxxxxxx> <551153C4.6000808@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
On 03/24/2015 02:08 PM, Boaz Harrosh wrote:
> On 03/24/2015 12:51 PM, Dave Chinner wrote:
> Regarding splice_write:
> It looks to me like you left the vector at iter_file_splice_write().
> If I understand correctly I think you need to call default_file_splice_write()
> that uses memcpy, just as it was at the previous patches when you left
> the vector NULL. So I think you need the same switch for write
> as you do below for read.

I take this back It looks like iter_file_splice_write() is perfectly usable
it relies on the source (Not us for write) being a page then kmaps and
calls one of f_op->write(file,..) or new_sync_write(file, ...) so
it looks like it all should work.

So the only bad thing is the comment it looks like splice should just
work also for dax.

Will be testing exact same thing for ext4 and report


> I'm doing the exact same code for ext4/2 right now and testing.
> (Thanks for the loop pointer).
> Otherwise I have stared at this very carefully and it looks good
> Did not test yet.
> Thanks
> Boaz

<Prev in Thread] Current Thread [Next in Thread>