Re: [PATCH] mkfs: default to CRC enabled filesystems

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 3/20/15 4:47 PM, Dave Chinner wrote:
> On Fri, Mar 20, 2015 at 10:26:49AM -0500, Eric Sandeen wrote:

...

>> I don't see how this requires xfstests rework, though?
> 
> About 50 tests fail with:

>     +warning: finobt not supported without CRC support, disabled.

> When run with MKFS_OPTIONS="-m crc=0".

Ok, I didn't mean it shouldn't be automatically disabled, I just meant
it should probably reject invalid option combinations on the cmdline.
 
> i.e. finobt is not specified, but mkfs issues warnings about it.
> 
> I've reworked the patch, anyway, so there's no need to continue the
> discussion on this...

Heh, ok.  <EOM>

-Eric