xfs
[Top] [All Lists]

Re: [PATCH] mkfs: default to CRC enabled filesystems

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] mkfs: default to CRC enabled filesystems
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 20 Mar 2015 16:56:53 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150320214719.GJ28621@dastard>
References: <1426720967-8215-1-git-send-email-david@xxxxxxxxxxxxx> <550AE35D.40006@xxxxxxxxxxx> <20150319231323.GK10105@dastard> <550C3C39.8050400@xxxxxxxxxxx> <20150320214719.GJ28621@dastard>
On 3/20/15 4:47 PM, Dave Chinner wrote:
> On Fri, Mar 20, 2015 at 10:26:49AM -0500, Eric Sandeen wrote:

...

>> I don't see how this requires xfstests rework, though?
> 
> About 50 tests fail with:

>     +warning: finobt not supported without CRC support, disabled.

> When run with MKFS_OPTIONS="-m crc=0".

Ok, I didn't mean it shouldn't be automatically disabled, I just meant
it should probably reject invalid option combinations on the cmdline.
 
> i.e. finobt is not specified, but mkfs issues warnings about it.
> 
> I've reworked the patch, anyway, so there's no need to continue the
> discussion on this...

Heh, ok.  <EOM>

-Eric

<Prev in Thread] Current Thread [Next in Thread>