[Top] [All Lists]

Re: [PATCH v3 3/3] NFSD: Add support for encoding multiple segments

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: [PATCH v3 3/3] NFSD: Add support for encoding multiple segments
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 20 Mar 2015 09:23:03 -0700
Cc: Marc Eshel <eshel@xxxxxxxxxx>, Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-nfs-owner@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150320151718.GD2036@xxxxxxxxxxxx>
References: <5509C0FD.70309@xxxxxxxxxx> <20150318185545.GF8818@xxxxxxxxxxxx> <5509E27C.3080004@xxxxxxxxxx> <20150318205554.GA10716@xxxxxxxxxxxx> <5509E824.6070006@xxxxxxxxxx> <20150318211144.GB10716@xxxxxxxxxxxx> <OFB111A6D8.016B8BD5-ON88257E0D.001D174D-88257E0D.005268D6@xxxxxxxxxx> <20150319153627.GA20852@xxxxxxxxxxxx> <OF38D4D18B.19055EC2-ON88257E0D.0059BA03-88257E0D.005A781F@xxxxxxxxxx> <20150320151718.GD2036@xxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Mar 20, 2015 at 11:17:18AM -0400, J. Bruce Fields wrote:
> Maybe this is a question for xfs developers.
> So, we have a new READ_PLUS call that's basically just a version of READ
> optimized for sparse files:
> http://tools.ietf.org/html/draft-ietf-nfsv4-minorversion2-33#section-15.10
> It allows an NFS server to return either file data (like a normal READ
> call) or, at the server's discretion, records saying "this range of the
> data is all zeroes".
> Anna tried implementing READ_PLUS for knfsd using
> vfs_llseek(.,.,SEEK_HOLE) followed by an ordinary read if that
> determines we're not at a hole.
> (Very) preliminary results suggest that's slower than a plain READ for
> an xfs file with no holes.  (And *much* slower in the ext4 case for some
> reason.)

It should be a fairly cheap operastion, and does extent tree operations
that are pretty similar to an (uncached) read.  Do you have profiles?

> Is that expected, and should we be doing this some other way instead?

Are the read cached or uncached?  If they are from pagecache just
copying the zeroes is pretty much unbeatable compared to extent
tree lookups, so we'd need a new page flag (difficult..) to see
that a page is a hole (and then it would only work for the whole page),
but for uncached reads an optimization would be to tell a read that it's
an NFS READ_PLUS so that it could just read until it reach a hole,
and then we'd need some way to communicate the hole size (or just fall
back to SEEK_HOLE for that case).

<Prev in Thread] Current Thread [Next in Thread>