[Top] [All Lists]

Re: panic on 4.20 server exporting xfs filesystem

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: panic on 4.20 server exporting xfs filesystem
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 20 Mar 2015 07:49:25 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150319184714.GB20852@xxxxxxxxxxxx>
References: <20150304225623.GZ4251@dastard> <20150305040849.GJ1627@xxxxxxxxxxxx> <20150305131731.GA16235@xxxxxx> <20150305150138.GA15674@xxxxxxxxxxxx> <20150305170217.GC15674@xxxxxxxxxxxx> <20150305204749.GA17934@xxxxxxxxxxxx> <20150305205922.GF18360@dastard> <20150306204715.GA27257@xxxxxxxxxxxx> <20150319172731.GA16329@xxxxxx> <20150319184714.GB20852@xxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Mar 19, 2015 at 02:47:14PM -0400, J. Bruce Fields wrote:
> Also, there's the problem that when this is turned on a client can end
> up doing unnecessary LAYOUTGET.  Do we have a plan for that?
> Possibilities:
>       - Just depend on export flags: but some clients may have direct
>         access and some not.  If the clients with direct access or all
>         easily identifiable by IP subnet, maybe it's not a big deal.
>         Still, seems like an administrative hassle.

We defintively want this to avoid getting into problems.

>       - Do nothing, assume the client can deal with this with some
>         kind of heuristics, and/or that the GETLAYOUT calls can be
>         made very cheap.  Not sure if that's true.

The calls itself are cheap, the cliet processing of them isn't.  I think we
should just stop issueing GETLAYOUT calls on the client side if we keep
errors again and again.  One option might be to add negative device id
cache entries, similar to how negative dentries work in the dcache.

>       - Use something like GETDEVLICELIST so the client can figure out
>         in one go whether any layouts on a given filesystem will work.
>         I forget what the problems with GETDEVICELIST were.

The way the device IDs rules are written in NFS it is inherently racy.

If I could go back 10 years in time I'd rewrite device ids to be stateids
bound to a fsid, and a lot of things could be fixed up neatly that way..

<Prev in Thread] Current Thread [Next in Thread>