Re: [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk

To:	Brian Foster <bfoster@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk
From:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:	Thu, 19 Mar 2015 12:27:26 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20150319164643.GD11669@xxxxxxxxxxxxxx>
References:	<1426624395-8258-1-git-send-email-sandeen@xxxxxxxxxx> <1426624395-8258-10-git-send-email-sandeen@xxxxxxxxxx> <20150319164643.GD11669@xxxxxxxxxxxxxx>

On 3/19/15 11:46 AM, Brian Foster wrote:

>> diff --git a/include/xfs_da_format.h b/include/xfs_da_format.h
>> index 89a1a21..695e698 100644
>> --- a/include/xfs_da_format.h
>> +++ b/include/xfs_da_format.h
>> @@ -561,7 +561,7 @@ xfs_dir3_dirent_get_ftype(
>>      if (xfs_sb_version_hasftype(&mp->m_sb)) {
>>              __uint8_t       type = dep->name[dep->namelen];
>>  
>> -            ASSERT(type < XFS_DIR3_FT_MAX);
>> +            //ASSERT(type < XFS_DIR3_FT_MAX);
> 
> Just delete it..?

Urgh.  yes.  I thought I had done so.

Thanks,
-Eric

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 07/13] xfs_repair: collapse 2 cases in process_sf_dir2, (continued) [PATCH 07/13] xfs_repair: collapse 2 cases in process_sf_dir2, Eric Sandeen [PATCH 03/13] xfs_db: add crc manipulation commands, Eric Sandeen Re: [PATCH 03/13] xfs_db: add crc manipulation commands, Brian Foster Re: [PATCH 03/13] xfs_db: add crc manipulation commands, Eric Sandeen Re: [PATCH 03/13] xfs_db: add crc manipulation commands, Brian Foster [PATCH 03/13 DROP] xfs_db: add crc manipulation commands, Eric Sandeen [PATCH 06/13] xfs_repair: remove impossible tests in process_sf_dir2, Eric Sandeen [PATCH 08/13] xfs_repair: remove last-entry hack in process_sf_dir2, Eric Sandeen [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk, Eric Sandeen Re: [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk, Brian Foster Re: [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk, Eric Sandeen <= PATCH 09/13 V2] libxfs: remove ASSERT on ftype read from disk, Eric Sandeen Re: PATCH 09/13 V2] libxfs: remove ASSERT on ftype read from disk, Brian Foster [PATCH 10/13] xfs_repair: clear need_root_dotdot if we rebuild the root dir, Eric Sandeen [PATCH 12/13] xfs_repair: don't clear . or .. in process_dir2_data, Eric Sandeen Re: [PATCH 12/13] xfs_repair: don't clear . or .. in process_dir2_data, Brian Foster Re: [PATCH 12/13] xfs_repair: don't clear . or .. in process_dir2_data, Eric Sandeen Re: [PATCH 12/13] xfs_repair: don't clear . or .. in process_dir2_data, Brian Foster Re: [PATCH 12/13] xfs_repair: don't clear . or .. in process_dir2_data, Eric Sandeen Re: [PATCH 12/13] xfs_repair: don't clear . or .. in process_dir2_data, Brian Foster [PATCH 12/13 V2] xfs_repair: don't clear . or .. in process_dir2_data, Eric Sandeen

Previous by Date:	Re: xfs write performance issue, Emmanuel Florac
Next by Date:	Re: panic on 4.20 server exporting xfs filesystem, Christoph Hellwig
Previous by Thread:	Re: [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk, Brian Foster
Next by Thread:	PATCH 09/13 V2] libxfs: remove ASSERT on ftype read from disk, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]