xfs
[Top] [All Lists]

Re: [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk

To: Brian Foster <bfoster@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 09/13] libxfs: remove ASSERT on ftype read from disk
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 19 Mar 2015 12:27:26 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150319164643.GD11669@xxxxxxxxxxxxxx>
References: <1426624395-8258-1-git-send-email-sandeen@xxxxxxxxxx> <1426624395-8258-10-git-send-email-sandeen@xxxxxxxxxx> <20150319164643.GD11669@xxxxxxxxxxxxxx>
On 3/19/15 11:46 AM, Brian Foster wrote:

>> diff --git a/include/xfs_da_format.h b/include/xfs_da_format.h
>> index 89a1a21..695e698 100644
>> --- a/include/xfs_da_format.h
>> +++ b/include/xfs_da_format.h
>> @@ -561,7 +561,7 @@ xfs_dir3_dirent_get_ftype(
>>      if (xfs_sb_version_hasftype(&mp->m_sb)) {
>>              __uint8_t       type = dep->name[dep->namelen];
>>  
>> -            ASSERT(type < XFS_DIR3_FT_MAX);
>> +            //ASSERT(type < XFS_DIR3_FT_MAX);
> 
> Just delete it..?

Urgh.  yes.  I thought I had done so.

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>