[Top] [All Lists]

Re: [PATCH 1/4] xfs_repair: validate & fix inode CRCs

To: Brian Foster <bfoster@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs_repair: validate & fix inode CRCs
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 13 Mar 2015 17:42:42 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150313132006.GA2678@xxxxxxxxxxxxxx>
References: <54F77199.8030708@xxxxxxxxxx> <54F771DE.40107@xxxxxxxxxxx> <20150313132006.GA2678@xxxxxxxxxxxxxx>
On 3/13/15 8:20 AM, Brian Foster wrote:


> What about verify_mode? It should probably report the inode as bunk if
> the crc is bad. Some of the subsequent checks handle this with some
> logic to just return 1 if something is bogus and we're in verify mode.

So, I read through the verify_mode portion on the plane ride back; I think
it's gotten a bit inconsistent over time.  I feel like I understand it a
bit better now, and will send a v3 which matches what I understand to be
its intent, and another patch to document it & make the rest consistent.

Thanks for keeping me honest.  ;)


<Prev in Thread] Current Thread [Next in Thread>