xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs_repair: dirty inode in process_sf_dir2 if we change

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs_repair: dirty inode in process_sf_dir2 if we change namelen
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 13 Mar 2015 10:34:17 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54FF5A5F.90201@xxxxxxxxxxx>
References: <54FF59DA.60700@xxxxxxxxxxx> <54FF5A5F.90201@xxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Mar 10, 2015 at 04:55:59PM -0400, Eric Sandeen wrote:
> There are two "fix sfep->namelen" cases, but we only mark
> *dino_dirty = 1 in one of them.  Add the other to ensure that
> the change gets written out.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> 
> diff --git a/repair/dir2.c b/repair/dir2.c
> index 6b8964d..25793e9 100644
> --- a/repair/dir2.c
> +++ b/repair/dir2.c
> @@ -881,6 +881,7 @@ _("entry \"%*.*s\" in shortform directory %" PRIu64 " 
> references %s inode %" PRI
>  _("zero length entry in shortform dir %" PRIu64 ", resetting to %d\n"),
>                                               ino, namelen);
>                                       sfep->namelen = namelen;
> +                                     *dino_dirty = 1;
>                               } else  {
>                                       do_warn(
>  _("zero length entry in shortform dir %" PRIu64 ", would set to %d\n"),
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>