xfs
[Top] [All Lists]

Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur

To: Mel Gorman <mgorman@xxxxxxx>
Subject: Re: [PATCH 4/4] mm: numa: Slow PTE scan rate if migration failures occur
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 12 Mar 2015 09:20:36 -0700
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Aneesh Kumar <aneesh.kumar@xxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, xfs@xxxxxxxxxxx, ppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=rFSSl2zee1g4jyehxhbkD/vDZCiGEgdRCN+heCqNptU=; b=iIbfGX7Cg4QbLIW9Lk+f9FgbO6kgSZzA3W44O+2S6W6+rZ93GmU1wCC2Q39r+m2O2p PkvbpY6zKLmSUrFDO2YvMSu0fOBpn+XwieLi+p8nITWMGwrNwJ0tjy8WlHa8wMIOZobb O3YpqzB/ETVJm3l76JmO6rC9SEqJ2Pg7KyKe35D8Wd80aaJGvdQ8ctaXmYZNE5AFPRGR 6X+PxXoX1Wh75rsHDr7uR/PQIWuhxw8lBEB0aWMjmd8nC3TIlRP7ggSIIOeba6VTzLqB 6tN6UVhU9IQ91Vdq7iz48yvpemH5Elw4XdHh8q1KscUkqihcpaw56gnRAWbNtoZtjjdS Vu3g==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=rFSSl2zee1g4jyehxhbkD/vDZCiGEgdRCN+heCqNptU=; b=NOun6E4mpZ58JGe2aPfHnuoLEMZ2jqwGGybZyqHYuz8Fb3Tazzrikge+2lmFYrRUWt UPii1KVTsJz8+nUXib1O76pKpAs8qTPoJKKtlnoSnh74tkhRMvR2NqEpmgi5hswll3SA CUJMTRY/ZORBVODiJv39XzZ/cUMdfDUFbP9fQ=
In-reply-to: <20150312131045.GE3406@xxxxxxx>
References: <1425741651-29152-1-git-send-email-mgorman@xxxxxxx> <1425741651-29152-5-git-send-email-mgorman@xxxxxxx> <20150307163657.GA9702@xxxxxxxxx> <CA+55aFwDuzpL-k8LsV3touhNLh+TFSLKP8+-nPwMXkWXDYPhrg@xxxxxxxxxxxxxx> <20150308100223.GC15487@xxxxxxxxx> <CA+55aFyQyZXu2fi7X9bWdSX0utk8=sccfBwFaSoToROXoE_PLA@xxxxxxxxxxxxxx> <20150309112936.GD26657@destitution> <CA+55aFywW5JLq=BU_qb2OG5+pJ-b1v9tiS5Ygi-vtEKbEZ_T5Q@xxxxxxxxxxxxxx> <20150309191943.GF26657@destitution> <CA+55aFzFt-vX5Jerci0Ty4Uf7K4_nQ7wyCp8hhU_dB0X4cBpVQ@xxxxxxxxxxxxxx> <20150312131045.GE3406@xxxxxxx>
Sender: linus971@xxxxxxxxx
On Thu, Mar 12, 2015 at 6:10 AM, Mel Gorman <mgorman@xxxxxxx> wrote:
>
> I believe you're correct and it matches what was observed. I'm still
> travelling and wireless is dirt but managed to queue a test using pmd_dirty

Ok, thanks.

I'm not entirely happy with that change, and I suspect the whole
heuristic should be looked at much more (maybe it should also look at
whether it's executable, for example), but it's a step in the right
direction.

So I committed it and added a comment, and wrote a commit log about
it. I suspect any further work is post-4.0-release, unless somebody
comes up with something small and simple and obviously better.

                                 Linus

<Prev in Thread] Current Thread [Next in Thread>