| To: | Fabian Frederick <fabf@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent |
| From: | Joe Perches <joe@xxxxxxxxxxx> |
| Date: | Tue, 03 Mar 2015 12:39:42 -0800 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1425410469-26098-1-git-send-email-fabf@xxxxxxxxx> |
| References: | <1425410469-26098-1-git-send-email-fabf@xxxxxxxxx> |
On Tue, 2015-03-03 at 20:21 +0100, Fabian Frederick wrote:
> new_parent is only used in 0/1 context.
[]
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
[]
> @@ -2860,7 +2860,7 @@ xfs_rename(
> {
> xfs_trans_t *tp = NULL;
> xfs_mount_t *mp = src_dp->i_mount;
> - int new_parent; /* moving to a new dir */
> + bool new_parent; /* moving to a new dir */
> int src_is_directory; /* src_name is a directory */
Could convert src_is_directory to bool too.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfs: don't release NULL pip in xfs_filestream_lookup_ag(), Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] [RFC] Implement XFS_IOC_FSBULKSTAT_RANGE ioctl, Eric Sandeen |
| Previous by Thread: | [PATCH] xfs: don't release NULL pip in xfs_filestream_lookup_ag(), Eric Sandeen |
| Next by Thread: | panic on 4.20 server exporting xfs filesystem, J. Bruce Fields |
| Indexes: | [Date] [Thread] [Top] [All Lists] |