xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: log unmount events on console

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: log unmount events on console
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2015 23:51:20 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150224115325.GA2356@xxxxxxxxxxxxxx>
References: <54EB7BDB.7080202@xxxxxxxxxx> <54EB7C65.3000307@xxxxxxxxxxx> <20150223204904.GC13522@xxxxxxxxxxxxx> <54EB9330.4080604@xxxxxxxxxxx> <20150223210629.GA9370@xxxxxxxxxxxxx> <20150224115325.GA2356@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 24, 2015 at 06:53:25AM -0500, Brian Foster wrote:
> On Mon, Feb 23, 2015 at 01:06:29PM -0800, Christoph Hellwig wrote:
> > On Mon, Feb 23, 2015 at 02:53:04PM -0600, Eric Sandeen wrote:
> > > On 2/23/15 2:49 PM, Christoph Hellwig wrote:
> > > > Oh well, even more spam during xfstest runs :)
> > > 
> > > Heh, but no review...?
> > > 
> > > I could be talked out of it, if people think it's not useful
> > > enough.
> > 
> > I can't really get excited enough either way to give a review or nak..
> > 
> 
> Heh, what verbosity is xfs_notice()? Maybe using debug level would be
> better?

The context Eric and I wanted to see this was when triaging bugs on
production systems. e.g. to know if someone unmounted a shut down
filesystem and tried to repair it before rebooting the system...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>